Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

giou_batch bug #1749

Closed
1 task done
DavidJenkins60 opened this issue Nov 21, 2024 · 1 comment
Closed
1 task done

giou_batch bug #1749

DavidJenkins60 opened this issue Nov 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@DavidJenkins60
Copy link

Search before asking

  • I have searched the Yolo Tracking issues and discussions and found no similar questions.

Yolo Tracking Component

Tracking

Bug

On line 122 of iou.py, giou_batch incorrectly subtracts the intersection "wh" from "area_enclose". It should subtract the combined area of the two boxes.

Environment

Visual code review

Minimal Reproducible Example

This is the line with the bug:
giou = iou - (area_enclose - wh) / area_enclose
@DavidJenkins60 DavidJenkins60 added the bug Something isn't working label Nov 21, 2024
@mikel-brostrom
Copy link
Owner

mikel-brostrom commented Nov 22, 2024 •
edited
Loading

Thanks for reporting this @DavidJenkins60 . This was fixed here: #1750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DavidJenkins60 @mikel-brostrom