Add support for ruamel.yaml #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breuleux
approved these changes
Sep 30, 2019
abergeron
force-pushed
the
switch_yaml
branch
7 times, most recently
from
a4aeb13 to
c39920f
Compare
abergeron
force-pushed
the
switch_yaml
branch
from
c39920f to
32a621c
Compare
|
The CI install modifications are done and working now. I had to create a new conda env because ruamel.yaml is a conda dependency and breaks conda if you install it from pip in the root env. |
breuleux
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ruamel.yaml merged the size_t fix after a couple of days (https://bitbucket.org/ruamel/yaml.clib/pull-requests/1/use-size_t-for-marks-in-cython-to-handle/diff) and PyYAML has apparently been "considering" a very similar fix for at least a month now: yaml/pyyaml#310, I believe it is in our best interest to possibly switch to ruamel.yaml in order to have a "fixed" version as soon as possible.
Also @ethancaballero and I did some runs using the python version of PyYAML and it is so slow that I consider it unusable for our purposes and therefore removed support.