Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next... #1

Open
miniflycn opened this issue Jan 12, 2014 · 9 comments
Open

Next... #1

miniflycn opened this issue Jan 12, 2014 · 9 comments

Comments

@miniflycn
Copy link
Owner

  • add test cases
  • support stream pipe
  • refactor url-valid and make it return a implement of Stream
@liviutudor
Copy link
Contributor

would also be worth supporting specifying the name of the file where the URL contents is being saved (as opposed to just basing it on the base url). I've sent a pull request for this.

@liviutudor
Copy link
Contributor

BTW I see you merged my pull request (thank you!) -- what is the plan/schedule for the next release (which includes it)?

@miniflycn
Copy link
Owner Author

There is nothing in the plan so far. Do you need any new features?

@liviutudor
Copy link
Contributor

It's only the change I sent in the pull request that I would like to be honest, the sooner the better really.

@miniflycn
Copy link
Owner Author

just npm install the new one, please

@liviutudor
Copy link
Contributor

hmmmm that would work locally but won't work when I deploy this (via a server that doesn't have the fix). I can live with this for now but would be great to know when this makes it in the npm registry so I don't have to do a lot of hacks to pull the version with the fix.

@miniflycn
Copy link
Owner Author

miniflycn commented Nov 7, 2016

But, Release 0.0.6 has been publish to npm an hour ago....

@liviutudor
Copy link
Contributor

oh right, that's what I was asking for -- I was not aware of that.
That includes my pull request changes, right?

@miniflycn
Copy link
Owner Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants