Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-performance from 1.12.0 to 1.13.0 #3236

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 27, 2021

Bumps rubocop-performance from 1.12.0 to 1.13.0.

Release notes

Sourced from rubocop-performance's releases.

RuboCop Performance 1.13.0

New features

Bug fixes

  • #277: Fix an incorrect autocorrect for Performance/MapCompact when using map.compact.first and there is a line break after map.compact and receiver. (@​koic)
  • #273: Fix an incorrect autocorrect for Performance/RedundantStringChars when using str.chars[0]. (@​koic)

Changes

  • #270: Mark Performance/Sum auto-correction as unsafe and extend documentation. (@​leoarnold)
  • #274: Unmark AutoCorrect: false from Performance/CaseWhenSplat. (@​koic)
  • #275: Unmark AutoCorrect: false from Performance/TimesMap. (@​koic)
Changelog

Sourced from rubocop-performance's changelog.

1.13.0 (2021-12-25)

New features

  • #276: Add new Performance/StringIdentifierArgument cop. ([@​koic][])
  • #204: Add Performance/Sum option to ignore potential false positives. ([@​leoarnold][])
  • #269: Add #to_d support to BigDecimalWithNumericArgument. ([@​leoarnold][])

Bug fixes

  • #277: Fix an incorrect autocorrect for Performance/MapCompact when using map.compact.first and there is a line break after map.compact and receiver. ([@​koic][])
  • #273: Fix an incorrect autocorrect for Performance/RedundantStringChars when using str.chars[0]. ([@​koic][])

Changes

  • #270: Mark Performance/Sum auto-correction as unsafe and extend documentation. ([@​leoarnold][])
  • #274: Unmark AutoCorrect: false from Performance/CaseWhenSplat. ([@​koic][])
  • #275: Unmark AutoCorrect: false from Performance/TimesMap. ([@​koic][])
Commits
  • 4c457c8 Cut 1.13.0
  • 4c9bae3 Update Changelog
  • 9a2d3d2 Remove redundant config from .rubocop.yml
  • f2dfcba Merge pull request #276 from koic/new_add_new_performance_string_identifier_a...
  • ce7f328 Allow for Gemfile.local
  • b9c1f05 Merge pull request #277 from koic/fix_incorrect_autocorrect_for_performance_m...
  • 1d7f986 Remove a redundant unsafe description
  • f45a323 Fix an incorrect autocorrect for Performance/MapCompact
  • 9a52662 Add new Performance/StringIdentifierArgument cop
  • bc3a349 Use \<<next>> instead of the next version when running rake new_cop
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Dec 27, 2021
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-performance@v1.12.0...v1.13.0)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-performance-1.13.0 branch from 1d6aca8 to 5227ffd Compare December 29, 2021 10:34
@mpw5 mpw5 added the On Hold Temporarily halting label Dec 29, 2021
@mpw5
Copy link
Contributor

mpw5 commented Dec 29, 2021

There's an issue with this update which is causing tests to fail: rubocop/rubocop-performance#278. I suggest waiting for that to be resolved.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 3, 2022

A newer version of rubocop-performance exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

mpw5 and others added 2 commits January 10, 2022 12:20
To keep Rubocop happy replace string identifier arguments with symbols.
@mpw5 mpw5 force-pushed the dependabot/bundler/rubocop-performance-1.13.0 branch from b6bb8a0 to a479a46 Compare January 10, 2022 12:20
@mpw5 mpw5 merged commit af41375 into main Jan 10, 2022
@mpw5 mpw5 deleted the dependabot/bundler/rubocop-performance-1.13.0 branch January 10, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file On Hold Temporarily halting ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants