Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-705 (revisited) Attempt to better customize webhint #668

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

MalcolmVonMoJ
Copy link
Contributor

@MalcolmVonMoJ MalcolmVonMoJ commented Jul 19, 2019

What

Link to story

Customized the webhint .hintrc file to allow for specific bypassing of hints that the GDS desing system will fail.
Confirmed what messages are okay with Oliver Byford at GDS and from the GDS list of known validation errors

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase master.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@MalcolmVonMoJ MalcolmVonMoJ added the WIP Work In Progress label Jul 19, 2019
@MalcolmVonMoJ MalcolmVonMoJ removed the WIP Work In Progress label Jul 19, 2019
@MalcolmVonMoJ MalcolmVonMoJ merged commit 8fe27c2 into master Jul 19, 2019
@MalcolmVonMoJ MalcolmVonMoJ deleted the ap-705-webhint branch July 19, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants