dns-certify-mirage: use X509.Private_key.of_string #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 16, 2023
…er, dns-mirage, dns-client, dns-client-mirage, dns-client-lwt, dns-cli and dns-certify (7.0.0) CHANGES: * BREAKING: dns-client is split into 3 packages: dns-client-lwt, dns-client-mirage. If your dune file contains dns-client.lwt, use dns-client-lwt now. If your dune file contains dns-client.mirage, use dns-client-mirage now (mirage/ocaml-dns#331 @hannesm) * update to mirage-crypto 0.11.0 API changes and tls 0.16.0 packaging changes (mirage/ocaml-dns#331 @hannesm) * dns-client.resolvconf: add line number to parser (mirage/ocaml-dns#334 @hannesm, inspired by mirage/ocaml-dns#328 @bikallem) * dns-client.resolvconf: allow zone idx (RFC 4007) for IPv6 entries (mirage/ocaml-dns#334 @hannesm, inspired by mirage/ocaml-dns#328 @bikallem) * dns-server.zone: allow zone files without final newline (add a newline to the buffer if the last character is not \n) (mirage/ocaml-dns#333 @hannesm) * dns-client-{lwt,mirage}: do not log when the resolver closed the connection, but there are no pending requests (mirage/ocaml-dns#332 @reynir) * dns-certify: in Dns_certify_mirage use X509.Private_key.of_string, the behaviour when both key_data and key_seed is provided changed, and leads to an exception now (mirage/ocaml-dns#330 @hannesm)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 16, 2023
…er, dns-mirage, dns-client, dns-client-mirage, dns-client-lwt, dns-cli and dns-certify (7.0.0) CHANGES: * BREAKING: dns-client is split into 3 packages: dns-client-lwt, dns-client-mirage. If your dune file contains dns-client.lwt, use dns-client-lwt now. If your dune file contains dns-client.mirage, use dns-client-mirage now (mirage/ocaml-dns#331 @hannesm) * update to mirage-crypto 0.11.0 API changes and tls 0.16.0 packaging changes (mirage/ocaml-dns#331 @hannesm) * dns-client.resolvconf: add line number to parser (mirage/ocaml-dns#334 @hannesm, inspired by mirage/ocaml-dns#328 @bikallem) * dns-client.resolvconf: allow zone idx (RFC 4007) for IPv6 entries (mirage/ocaml-dns#334 @hannesm, inspired by mirage/ocaml-dns#328 @bikallem) * dns-server.zone: allow zone files without final newline (add a newline to the buffer if the last character is not \n) (mirage/ocaml-dns#333 @hannesm) * dns-client-{lwt,mirage}: do not log when the resolver closed the connection, but there are no pending requests (mirage/ocaml-dns#332 @reynir) * dns-certify: in Dns_certify_mirage use X509.Private_key.of_string, the behaviour when both key_data and key_seed is provided changed, and leads to an exception now (mirage/ocaml-dns#330 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the only semantic difference is when neither "key_data" nor "key_seed" is provided, in which case we error out now.
I think that's fine (I checked all cloned unikernels on my hard drive), but am happy to hear other thoughts.