Skip to content

Commit

Permalink
pythongh-87497: Document that urllib.request sends headers in camel c…
Browse files Browse the repository at this point in the history
…ase (pythonGH-24661)

Co-authored-by: Jelle Zijlstra <[email protected]>
  • Loading branch information
axel3rd and JelleZijlstra authored Apr 14, 2022
1 parent 5f056ac commit 325d6f5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions Doc/library/urllib.request.rst
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ The following classes are provided:
(X11; U; Linux i686) Gecko/20071127 Firefox/2.0.0.11"``, while
:mod:`urllib`'s default user agent string is
``"Python-urllib/2.6"`` (on Python 2.6).
All header keys are sent in camel case.

An appropriate ``Content-Type`` header should be included if the *data*
argument is present. If this header has not been provided and *data*
Expand Down
9 changes: 9 additions & 0 deletions Lib/test/test_urllib2_localnet.py
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,15 @@ def test_sending_headers(self):
pass
self.assertEqual(handler.headers_received["Range"], "bytes=20-39")

def test_sending_headers_camel(self):
handler = self.start_server()
req = urllib.request.Request("http://localhost:%s/" % handler.port,
headers={"X-SoMe-hEader": "foobar"})
with urllib.request.urlopen(req):
pass
self.assertIn("X-Some-Header", handler.headers_received.keys())
self.assertNotIn("X-SoMe-hEader", handler.headers_received.keys())

def test_basic(self):
handler = self.start_server()
with urllib.request.urlopen("http://localhost:%s" % handler.port) as open_url:
Expand Down

0 comments on commit 325d6f5

Please sign in to comment.