Announcement Image URL cannot be deleted during creation | アナウンスメントを作成ときにWebUIフォームの画像URLを後悔できない

[eternal-flame-AD]

💡 Summary

タイトル通りです

misskey/packages/backend/src/server/api/endpoints/admin/announcements/update.ts

Lines 59 to 71 in 9614f74

	await this.announcementService.update(announcement, {
	updatedAt: new Date(),
	title: ps.title,
	text: ps.text,
	/* eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- 空の文字列の場合、nullを渡すようにするため */
	imageUrl: ps.imageUrl || null,
	display: ps.display,
	icon: ps.icon,
	forExistingUsers: ps.forExistingUsers,
	silence: ps.silence,
	needConfirmationToRead: ps.needConfirmationToRead,
	isActive: ps.isActive,
	}, me);

misskey/packages/backend/src/server/api/endpoints/admin/announcements/create.ts

Lines 75 to 85 in 9614f74

	const { raw, packed } = await this.announcementService.create({
	updatedAt: null,
	title: ps.title,
	text: ps.text,
	imageUrl: ps.imageUrl,
	icon: ps.icon,
	display: ps.display,
	forExistingUsers: ps.forExistingUsers,
	silence: ps.silence,
	needConfirmationToRead: ps.needConfirmationToRead,
	userId: ps.userId,

Proposed fix

https://forge.yumechi.jp/yume/yumechi-no-kuni/commit/13e50cd8d9e1f8e2d91c0ca387206b904c495fe5

diff --git a/packages/backend/src/server/api/endpoints/admin/announcements/create.ts b/packages/backend/src/server/api/endpoints/admin/announcements/create.ts
index 2dae1df87d..b8bfda73a4 100644
--- a/packages/backend/src/server/api/endpoints/admin/announcements/create.ts
+++ b/packages/backend/src/server/api/endpoints/admin/announcements/create.ts
@@ -55,7 +55,7 @@ export const paramDef = {
 	properties: {
 		title: { type: 'string', minLength: 1 },
 		text: { type: 'string', minLength: 1 },
-		imageUrl: { type: 'string', nullable: true, minLength: 1 },
+		imageUrl: { type: 'string', nullable: true, minLength: 0 },
 		icon: { type: 'string', enum: ['info', 'warning', 'error', 'success'], default: 'info' },
 		display: { type: 'string', enum: ['normal', 'banner', 'dialog'], default: 'normal' },
 		forExistingUsers: { type: 'boolean', default: false },
@@ -76,7 +76,8 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint-
 				updatedAt: null,
 				title: ps.title,
 				text: ps.text,
-				imageUrl: ps.imageUrl,
+				/* eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- 空の文字列の場合、nullを渡すようにするため */
+				imageUrl: ps.imageUrl || null,
 				icon: ps.icon,
 				display: ps.display,
 				forExistingUsers: ps.forExistingUsers,

🥰 Expected Behavior

1. See "Steps to Reproduce"
2. 200 OK

🤬 Actual Behavior

1. See "Steps to Reproduce"
2. 400 Bad Request

📝 Steps to Reproduce

1. https://misskey-hub.net/en/mi-web/?path=/admin/announcements
2. 追加
3. title <- "Test"
4. text <- "Text"
5. 画像URL <- "AAA"
6. 画像URL <- Backspace *3
7. 保存

💻 Frontend Environment

Not a frontend problem

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service: Docker-compose.yml (https://forge.yumechi.jp/yume/yumechi-no-kuni/src/branch/develop/compose_example.yml)
* Misskey: [2024.11.0-yumechinokuni.4p1](https://forge.yumechi.jp/yume/yumechi-no-kuni/src/tag/2024.11.0-yumechinokuni.4p1) (tracking misskey-dev#develop)
* OS and Architecture: Arch Linux x86_64

Do you want to address this bug yourself?

• Yes, I will patch the bug myself and send a pull request