-
Notifications
You must be signed in to change notification settings - Fork 573
make rsync --exclude configurable #152
Comments
see #141 |
@tralamazza - I do not think that using .gitignore is the right solution. Here is why. A very common workflow is: clone -> edit -> build -> deploy -> test -> commit. .gitignore - serves the purpose of preventing artifacts of build and test stages from being committed. Therefore .gitignore and .vagrantignore do not necessarily overlap. In fact, what we are trying to do looks more like partitioning. |
And whatever the "ignore" file is used, it shouldn't suddenly become required. Things will break everywhere. |
Just to make things clearer, .gitignore is always shipped with the gem (so there is no way it would be missed), this change is not published AND it will actually be reverted ^^ btw: The exclude parameter should not be a region config, but rather a per share config. |
+1 for this -- I store transitory test data in my local git repo (under a .gitignore subdir) and I don't want to wait/pay for it to rsync to each of my instances. I don't care if the file uses .gitignore or .vagrant-aws-rsync-ignore or similar, either way is fine. |
Merged #156. |
Since we are pushing stuff over the network, it would be beneficial to be able to filter out stuff we don't need on the VM from the project directory (e.g. .git).
I can see doing this using Vagrantfile or using a .xxx-ignore file of some kind (similar to .gitignore).
The text was updated successfully, but these errors were encountered: