Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

make rsync --exclude configurable #152

Closed
vasili-zolotov opened this issue Oct 9, 2013 · 6 comments
Closed

make rsync --exclude configurable #152

vasili-zolotov opened this issue Oct 9, 2013 · 6 comments

Comments

@vasili-zolotov
Copy link
Contributor

Since we are pushing stuff over the network, it would be beneficial to be able to filter out stuff we don't need on the VM from the project directory (e.g. .git).

I can see doing this using Vagrantfile or using a .xxx-ignore file of some kind (similar to .gitignore).

@tralamazza
Copy link
Collaborator

see #141

@vasili-zolotov
Copy link
Contributor Author

@tralamazza - I do not think that using .gitignore is the right solution. Here is why. A very common workflow is: clone -> edit -> build -> deploy -> test -> commit.

.gitignore - serves the purpose of preventing artifacts of build and test stages from being committed.
.vagrantignore - hypothetically serves the purpose of filtering out most things other than output of build stage.

Therefore .gitignore and .vagrantignore do not necessarily overlap. In fact, what we are trying to do looks more like partitioning.

@vasili-zolotov
Copy link
Contributor Author

And whatever the "ignore" file is used, it shouldn't suddenly become required. Things will break everywhere.

@tralamazza
Copy link
Collaborator

Just to make things clearer, .gitignore is always shipped with the gem (so there is no way it would be missed), this change is not published AND it will actually be reverted ^^

btw: The exclude parameter should not be a region config, but rather a per share config.

@jayjanssen
Copy link

+1 for this -- I store transitory test data in my local git repo (under a .gitignore subdir) and I don't want to wait/pay for it to rsync to each of my instances. I don't care if the file uses .gitignore or .vagrant-aws-rsync-ignore or similar, either way is fine.

@tralamazza
Copy link
Collaborator

Merged #156.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants