This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
support user specified rsync excludes. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows to specify subfolders that should be excluded from syncing via synced_folder options: e.g.: config.vm.synced_folder '.', '/vagrant', :rsync_excludes => ['chef/tmp', 'tmp']
|
haha I had the exact same implementation in a local branch ;) |
|
I'm still not convinced about super specific rsync flags though :/ |
| @@ -66,11 +66,14 @@ def call(env) | |||
| env[:machine].communicate.sudo("mkdir -p '#{guestpath}'") | |||
| env[:machine].communicate.sudo( | |||
| "chown #{ssh_info[:username]} '#{guestpath}'") | |||
|
|
|||
| #collect rsync excludes specified :rsync_excludes=>['path1',...] in synced_folder options | |||
| excludes = ['.vagrant/', 'Vagrantfile', *Array(data[:rsync_excludes])] | |||
There was a problem hiding this comment.
adding a .uniq wouldn't hurt I think
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a simple solution for configurable rsync excludes requested in #140 and #152.
Instead of introducing a new plugin specific configuration option this change uses the already existing options hash of synced folders.
It allows to specify excludes for each defined synced folder in the Vagrantfile.
e.g.: