Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Could not run logical plan" error should not be Internal Server Error #184

Open
cchudant opened this issue Jan 12, 2023 · 1 comment
Open
Labels
A-server Area: Server C-bug Category: Bug

Comments

@cchudant
Copy link
Contributor

GRPCException: Internal server error: code=StatusCode.INTERNAL message=Could not run logical plan: Data types don't match: Series of dtype: Date != Utf8

should not be internal server error, it should be BadRequest/other

No reproduction code; the actual problematic code should be obvious with a simple grep on the codebase

Also, internal server errors should be logged to the console, as they mean something wrong happened (the kind of logical bugs that should never happen)

@cchudant cchudant added A-server Area: Server C-bug Category: Bug labels Jan 12, 2023
@dhalf
Copy link
Contributor

dhalf commented Jan 13, 2023

Agreed we could use INVALID_ARGUMENT instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-server Area: Server C-bug Category: Bug
Projects
None yet
Development

No branches or pull requests

2 participants