-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix user creation for users with accented characters in their usernames #259
Comments
@gsidebo so do you think we restrict user creation for users with accented characters in their usernames here ? in terms of some restrict to use specific characters in username ? |
from Slack
|
@asadiqbal08 The problem is that we already have users with accented characters in their usernames. Even if we restrict it on our end from now on, an un-accented new username might still collide with an existing accented username. The "simplest" fix for this would be to restrict the usernames on our end as your suggested, then right after that merges, mass-update all existing usernames in edX to remove accented characters via script. This might require us to notify users. We'd have to ask leadership and customer service about what our policy should be. Another option would be to check that the MySQL issue described above is the actual source of the problem, then look into the possibility of reconfiguring the database. |
Note that when we were looking into some other issues with usernames, we discovered a few users who have a username conflict due to the fact that there are some usernames that differ only by accents. They can be found in the |
Steps to Reproduce
online-user
andönlínê-user
)Expected Behavior
The users exist in both mitxonline and Open edX
Actual Behavior
For unexplained reasons, edX treats both of those usernames as the same, so only the more recent user will have a User record on the Open edX side, and one or both users will experience some of the auth/enrollment issues that we saw before we patched up username creation and validation
Related Issues
#202
#244
Implementation
User
model (normalized_username
or something like that)username
with accent characters 'normalized' to unaccented versions.username
valueüser1
already exists, then someone else tries to create a user with usernameuser1
. That should trigger a validation error, and they should see the messageUsername 'user1' already exists
or whatever the validation message is currently for an exact-match username collision. It's not necessary to tell them about the accented character constraints – we should be fine with just telling them to try a different usernameThe text was updated successfully, but these errors were encountered: