Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should tables be allowed to interrupt a paragraph? #108

Closed
mity opened this issue Feb 24, 2020 · 3 comments
Closed

Should tables be allowed to interrupt a paragraph? #108

mity opened this issue Feb 24, 2020 · 3 comments
Labels

Comments

@mity
Copy link
Owner

mity commented Feb 24, 2020

So far we have not allowed the interruption in order to be compatible with cmark-gfm.

But github/cmark-gfm#141 shows it has been considered a bug rather than an intended feature. (However lets maybe wait until they decide what to do about the current state when cmark-gfm detects it only for some tables.)

@mity
Copy link
Owner Author

mity commented Feb 24, 2020

Track also github/cmark-gfm#180

@niblo
Copy link
Contributor

niblo commented Feb 25, 2020

My opinion is to not allow the interruption.

The GFM spec doesn't seem to have much to say about it from what I can see: https://github.github.com/gfm/

@mity
Copy link
Owner Author

mity commented Feb 26, 2020

Indeed, GFM specs does not say much about it. But the GFM extensions are all underspecified in many directions in that document. That said, cmark-gfm is de-facto the reference implementation of that specification. That's what is used on github.com and what people expect when you spell GFM. Therefore, being reasonably compatible with it even beyond the specification makes sense.

For now, I will likely keep the behavior as it is, given cmark-gfm behaves inconsistently (github/cmark-gfm#179, github/cmark-gfm#180). However when/if they resolve it in any reasonable and consistent way, we will then likely follow.

(Keeping the issue open as a reminder to track it.)

@mity mity changed the title Tables should likely be allowed to interrupt a paragraph. Should tables be allowed to interrupt a paragraph? Mar 10, 2020
@mity mity closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants