Reduce saveState data in sessionStorage #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some tests around this? |
|
@taion |
koba04
force-pushed
the
reduce-savestate-data-in-session-storage
branch
from
387ac7a to
1d0ebe3
Compare
koba04
force-pushed
the
reduce-savestate-data-in-session-storage
branch
from
1d0ebe3 to
009cbc3
Compare
|
@taion |
|
Thanks! |
taion
added a commit
that referenced
this pull request
Jan 1, 2016
…storage Reduce saveState data in sessionStorage
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using history with react-router. Thank you for your great work!
I'm using Session Storage wth my app.
So I often confirm the developer console for debugging app data in Session Storage.
history is adding a state to sessionStorage every history changes.
As a result, my Session Storage is filled by history's state regardless of using it.
This behavior makes my debugging hard.
My PR is for that it saves history's state in Session Storage only when history's state is not empty.
Thanks!