installed-page: Save extension's toggle focus on state changes #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscfdezdz
force-pushed
the
fix-focus-loss
branch
3 times, most recently
from
6426d3d to
93f6210
Compare
The items-changed signal is now emitted without adding or removing items to the model from ExmManager and is connected after binding the manager in ExmInstalledPage from where the callback saves, emits items-changed adding and removing as done before in ExmManager, and restores focus. This approach allows us to keep binding GtkListBox to the extensions model and not having to manage the changes manually. Fix #220
oscfdezdz
force-pushed
the
fix-focus-loss
branch
from
93f6210 to
d195ee2
Compare
oscfdezdz
force-pushed
the
fix-focus-loss
branch
from
d195ee2 to
9bfb9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The items-changed signal is now emitted without adding or removing items to the model from ExmManager and is connected after binding the manager in ExmInstalledPage from where the callback saves, emits items-changed adding and removing as done before in ExmManager, and restores focus.
This approach allows us to keep binding GtkListBox to the extensions model and not having to manage the changes manually.
Fix #220