Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Don't launch an initial search on an empty SearchEntry #691

Open
nekohayo opened this issue Jul 25, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@nekohayo
Copy link

Describe the bug

Currently, the app launches a search immediately the first time you switch to the "Browse" tab, even if the user hasn't typed anything, and this empty search takes a very long time (ex: 30 seconds or so) with the spinner active throughout this time. This should not happen:

Screencast.from.2024-07-25.07-52-19.mp4

System Information:

  • Distro: Fedora 40
  • Extension Manager version: 0.5.1
  • Package format: Flatpak
@oscfdezdz oscfdezdz added the enhancement New feature or request label Aug 6, 2024
@oscfdezdz
Copy link
Collaborator

For context, this happened because the servers were down for maintenance and apparently it took longer than expected and affected other services, see https://discourse.gnome.org/t/planned-maintenance-ocp-cluster-25th-of-july-2024-8-am-12-pm-utc/22321/8

Regardless, as you mentioned in #672 (comment), we should show a warning when there is a problem with the servers.

To avoid launching an initial search when switching to the Browse tab, maybe we could cache the most popular extensions from time to time. Although it seems that the Extensions website does an initial search every time, just like we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants