Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faceMesh lips missing keypoint 291 #107

Closed
jackbdu opened this issue Mar 23, 2024 · 3 comments · Fixed by #108
Closed

faceMesh lips missing keypoint 291 #107

jackbdu opened this issue Mar 23, 2024 · 3 comments · Fixed by #108

Comments

@jackbdu
Copy link

jackbdu commented Mar 23, 2024

Hi all, I noticed in the faceMesh parts example, there is a missing keypoint (291 on the mesh_map). See this sketch with keypoint 291 drawn in red. The same issue is present in the original tfjs demo so I'm not sure what we should do. Would it make sense to manually add this keypoint in ml5 for the time being (until it's fixed in tfjs)?

@ziyuan-linn
Copy link
Member

@jackbdu thank you for submitting this issue! We certainly should open an issue with tfjs about this. In the meantime, it should be simple to fix this within ml5 temporarily.

@ziyuan-linn ziyuan-linn linked a pull request Mar 23, 2024 that will close this issue
@shiffman
Copy link
Member

Thank you @jackbdu for reporting and @ziyuan-linn for adding support! How does this affect the documentation? cc @B2xx who is working on this. Does anyone want to volunteer to open the tf.js issue?

@jackbdu jackbdu changed the title Facemesh lips missing keypoint 291 faceMesh lips missing keypoint 291 Mar 23, 2024
@jackbdu
Copy link
Author

jackbdu commented Mar 23, 2024

@ziyuan-linn Thank you for addressing this so quickly!

@shiffman I went ahead and opened an issue about this on tfjs repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants