-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HandPose Connections #224
Comments
This looks great! I also think it is a good idea to add connections for Looks like the official standards are defined in constants.ts. I think we can import it with Going back to the previous discussion, perhaps we can also add |
@shiffman I just made a PR to add the I noticed that there is a small difference between the official connections array and the diagram. This is from the connections array: Which of the two connection schemes do you think we should use? |
Oh interesting! I think it probably makes sense to follow the official ones! It's just strange that the official connections don't match the diagram? It's not so many keypoints that someone couldn't easily build their own list if they prefer a different visual. Maybe @MOQN has a preference? (Just linking this to #227 for reference also) |
@shiffman Thank you for looping me in! I really don’t have any preference, but I’m leaning toward following the official version, like the one in @ziyuan-linn’s screenshot. I just searched for the actual hand skeleton, and it’s similar to the official connections, haha 😂. (I do feel the same though, about the diagram in their documentation.) (Just a random thought: if we don't follow the official connections, we could consider connecting the points 1 and 5, instead of 0 and 5.) |
Picking up on #231, I would like to propose adding
getConnections()
toml5.handPose()
. According to the official diagram, these are the connections. (I made this manually and the order is somewhat arbitrary. Is there an official standard?)The text was updated successfully, but these errors were encountered: