Off by one error with $Knn_Query()

[jefferys]

Using nmslibR_1.0.3, I'm getting an off by one error in the returned index of the similar row from $KnnQuery().

> x <- rbind( c(1,1,1,1), c(2,2,2,2), c(1,1,50,50), c(2,2,51,51), c(1,2,1,2), c(1,2,51,50) )
> x
     [,1] [,2] [,3] [,4]
[1,]    1    1    1    1
[2,]    2    2    2    2
[3,]    1    1   50   50
[4,]    2    2   51   51
[5,]    1    2    1    2
[6,]    1    2   51   50

> dataBase <- NMSlib$new( x, method= "hnsw", space= "l2" )
> dataBase$Knn_Query( x[1,], k= 1 )
> result
[[1]]
[1] 4

[[2]]
[1] 1.414214

> x[4,]
[1]  2  2 51 51

[mlampros]

hi @jefferys,
thanks for making me aware of the this issue. It was a difference in indexing between R and Python. I fixed it, you can download the updated version using

remotes::install_github(repo = 'mlampros/nmslibR')

[jefferys]

Thanks; looks like this is fixed now. Also, for the historical record, wanted to point out that this did not affect the $knn_Query_Batch() function; that was and is returning the correct indexes.

[mlampros]

The Knn_Query() and the knn_Query_Batch() are two different methods of the NMSlib R6 class. Although, I took into account the difference in indexing in the knn_Query_Batch() method I omitted to do the same for the Knn_Query() method. Thanks again for spotting this issue.

[stale]

This is Robo-lampros because the Human-lampros is lazy. This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 7 days if no further activity occurs. Feel free to re-open a closed issue and the Human-lampros will respond.