Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When customising the output the field "callingCodes" is excluded #475

Closed
BenJackGill opened this issue May 5, 2023 · 4 comments
Closed

Comments

@BenJackGill
Copy link

I am running this custom output command: php countries.php convert --include-field=name --include-field=cca2 --include-field=callingCodes

But only name and cca2 are included in the output. callingCodes field is always excluded.

@BenJackGill
Copy link
Author

BenJackGill commented May 5, 2023

Update: If you want callingCodes then you need to use --include-field=idd. The output will then have both idd and callingCodes fields automatically included. It seems you cannot just get callingCodes alone.

For example, my previous command would be php countries.php convert --include-field=name --include-field=cca2 --include-field=idd

If this is the intended behaviour I suggest updating the readme doc to reflect that.

@mledoze
Copy link
Owner

mledoze commented Sep 12, 2023

Hi,

I think this is an unintended consequence of #389. I will look into it.

@mledoze
Copy link
Owner

mledoze commented Sep 12, 2023

@BenJackGill I have prepared a fix for this here #487, which will be released in the 5.0 version.

Thank you for your patience.

@mledoze
Copy link
Owner

mledoze commented Sep 13, 2023

fixed via #487

@mledoze mledoze closed this as completed Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants