Merge demonym into demonyms

[alexsegura]

Fixes #368

[mledoze]

Thank you for this. Do you mind putting eng before fra to respect the alphabetic order?

[alexsegura]

@mledoze here you go

At first I thought it wouldn't be possible as object properties would get serialized in an unpredictable order, but it's as simple as setting the object keys in the order you expect.

💙PHP 💙

<?php

$countries = json_decode(file_get_contents('./countries.json'));

foreach ($countries as $key => $country) {
    if (isset($country->demonyms) && isset($country->demonym)) {

        $demonyms_eng = new \stdClass();
        $demonyms_eng->f = $country->demonym;
        $demonyms_eng->m = $country->demonym;

        $demonyms = $country->demonyms;

        unset($country->demonym);
        unset($country->demonyms);

        $country->demonyms = new \stdClass();

        $countries[$key]->demonyms->eng = $demonyms_eng;
        $countries[$key]->demonyms->fra = $demonyms->fra;
    }
}

file_put_contents('./countries.json', json_encode($countries, JSON_PRETTY_PRINT));

[mledoze]

Or you could just use ksort for a simpler and more generic solution; here is a tested example:

$countries = json_decode(file_get_contents('countries.json'), true);

$countries = array_map(static function ($country) {
    if (isset($country['demonyms'], $country['demonym'])) {
        $country['demonyms']['eng'] = [
            'f' => $country['demonym'],
            'm' => $country['demonym'],
        ];
        ksort($country['demonyms']);
        unset($country['demonym']);
    }
    return $country;
}, $countries);

file_put_contents('countries.json', json_encode($countries, JSON_PRETTY_PRINT));

[mledoze]

Could you also remove the description of the demonym property in the README?

[alexsegura]

Done.

[mledoze]

It's merged, thank you for your help on this. I will draft a new release now.