Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swedish translations to countries.json (both common and official) #398

Merged
merged 4 commits into from
Jun 9, 2020
Merged

Add Swedish translations to countries.json (both common and official) #398

merged 4 commits into from
Jun 9, 2020

Conversation

aleksitaipale
Copy link
Contributor

This pull request adds the Swedish translations to countries.json, both official ones as well as common ones.

The common names have been sourced from the ISO 3166 article on Swedish Wikipedia.

The official names have been sourced from the Swedish Wikipedia pages of individual countries. Hence, for example Finland becomes Republiken Finland, as it is defined in Finland's Wikipedia article. In these articles, the preceding text "officiellt" (officially) or "formellt" (formally) signifies the official naming.

When no official naming has been provided in the Wikipedia article, I have kept both the common and official name the same.

If I'm missing something or something is wrong, do say! :)

P.S. I know that in #170 there was an intent to add all the Scandinavian languages. However, no official names were provided then and the PR got closed. This PR only adds Swedish, but also includes the official names.

@mledoze
Copy link
Owner

mledoze commented Jun 1, 2020

Hello @aleksitaipale, thank you for this pull request and your great work.
I will review it this week.

@mledoze
Copy link
Owner

mledoze commented Jun 1, 2020

Could you please keep the alphabetical order of the translations keys and add an entry in the changelog?
Thank you

@aleksitaipale
Copy link
Contributor Author

Thank you for the quick reply! @mledoze, I have now updated the changelog in 90eb437, and ordered the swe translation keys to their correct position in 8b96ce7. :)

@mledoze mledoze merged commit 4b8628f into mledoze:master Jun 9, 2020
@mledoze
Copy link
Owner

mledoze commented Jun 9, 2020

It's merged, thank you for your work.

The official names have been sourced from the Swedish Wikipedia pages of individual countries.

Did you do this manually or with a script?

@aleksitaipale
Copy link
Contributor Author

Hi, thanks for checking this out!

Unfortunately I sourced the official names manually, one-by-one. :P For the common . names I used a script that parsed the Wikipedia table, if I recall correctly. But there was no such table for the official names, sadly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants