Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D figure rendering to documentation #981

Closed
hoechenberger opened this issue Mar 8, 2022 · 2 comments
Closed

Add 3D figure rendering to documentation #981

hoechenberger opened this issue Mar 8, 2022 · 2 comments
Labels

Comments

@hoechenberger
Copy link
Member

we don't support pyvista and 3D plots in the doc of mne-bids... to be done later I guess

Originally posted by @agramfort in #980 (review)

cc @larsoner

@larsoner
Copy link
Member

larsoner commented Mar 8, 2022

Adding a scraper for plot_alignment or other things that just use a simple 3D scene is as simple as adding 'image_scrapers': ('pyvista', ...) to sphinx_gallery-conf in principle. In practice you then need to make sure it actually renders properly.

If you want stc.plot or something, you want _BrainScraper or so, but it's still doable.

I'd wait until you had a use case, then I'm happy to help. It sounds like you can't actually use it for #980 because you don't have the right files (?).

@sappelhoff
Copy link
Member

Do we still need this? Where are we missing a 3D figure in our docs?

This was the example worked on in #980: https://mne.tools/mne-bids/stable/auto_examples/convert_ieeg_to_bids.html#sphx-glr-auto-examples-convert-ieeg-to-bids-py

looks fine to me? I'd close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants