-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Tolerate new MNE behavior #1076
Conversation
I also just pushed a commit to avoid using conda-forge/mne-bids-feedstock#21 Keeping it would mean 1) adding to setup.py deps, probably dependent on Python version, 2) changing the import, probably with a try/except, 3) updating the feedstock. What I've implemented here instead is just |
Sounds good to me. Some tests are still failing though! |
Those should be fixed by mne-tools/mne-python#11230 |
Codecov Report
@@ Coverage Diff @@
## main #1076 +/- ##
==========================================
- Coverage 95.21% 95.21% -0.01%
==========================================
Files 24 24
Lines 3845 3844 -1
==========================================
- Hits 3661 3660 -1
Misses 184 184
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ready for review/merge from my end |
Thanks @larsoner |
Yes we should have, thanks @sappelhoff ! |
@hoechenberger should fix the failing test following mne-tools/mne-python#11212 where fiducials are estimated and added when implicitly converting to the head coordinate frame