Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Tolerate new MNE behavior #1076

Merged
merged 3 commits into from
Oct 8, 2022
Merged

MAINT: Tolerate new MNE behavior #1076

merged 3 commits into from
Oct 8, 2022

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Oct 7, 2022

@hoechenberger should fix the failing test following mne-tools/mne-python#11212 where fiducials are estimated and added when implicitly converting to the head coordinate frame

@larsoner
Copy link
Member Author

larsoner commented Oct 7, 2022

I also just pushed a commit to avoid using importlib_resources. It's causing a conda-forge build error:

conda-forge/mne-bids-feedstock#21

Keeping it would mean 1) adding to setup.py deps, probably dependent on Python version, 2) changing the import, probably with a try/except, 3) updating the feedstock. What I've implemented here instead is just data_dir = Path(__file__).parent / 'data' which requires none of these gymnastics, and hopefully is good enough.

@hoechenberger
Copy link
Member

Sounds good to me. Some tests are still failing though!

@larsoner
Copy link
Member Author

larsoner commented Oct 7, 2022

Those should be fixed by mne-tools/mne-python#11230

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #1076 (f744663) into main (de529c4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
- Coverage   95.21%   95.21%   -0.01%     
==========================================
  Files          24       24              
  Lines        3845     3844       -1     
==========================================
- Hits         3661     3660       -1     
  Misses        184      184              
Impacted Files Coverage Δ
mne_bids/dig.py 98.26% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@larsoner
Copy link
Member Author

larsoner commented Oct 7, 2022

Ready for review/merge from my end

@sappelhoff sappelhoff merged commit 7b52eab into mne-tools:main Oct 8, 2022
@sappelhoff
Copy link
Member

Thanks @larsoner

@sappelhoff
Copy link
Member

sappelhoff commented Oct 8, 2022

we should probably have removed this line as well with this PR, right?

importlib-resources

done in #1077

@larsoner larsoner deleted the fids branch October 9, 2022 18:48
@larsoner
Copy link
Member Author

larsoner commented Oct 9, 2022

Yes we should have, thanks @sappelhoff !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants