Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix canonical ref #1333

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix canonical ref #1333

merged 1 commit into from
Nov 5, 2024

Conversation

drammock
Copy link
Member

@drammock drammock commented Nov 5, 2024

PR Description

closes #1332

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.45%. Comparing base (ea5a6a7) to head (e4db95e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
- Coverage   97.47%   97.45%   -0.03%     
==========================================
  Files          40       40              
  Lines        8876     8876              
==========================================
- Hits         8652     8650       -2     
- Misses        224      226       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drammock
Copy link
Member Author

drammock commented Nov 5, 2024

@sappelhoff only CI failure is BIDS-Validator app failing to install (clearly unrelated).

I checked randomly this page: https://output.circle-artifacts.com/output/job/6ca7c669-2237-4da5-867e-a97aa9561bb1/artifacts/0/dev/generated/mne_bids.write_raw_bids.html

and in the header I see

<link rel="canonical" href="https://mne.tools/mne-bids/stable/generated/mne_bids.write_raw_bids.html">

(which is correct)

@sappelhoff
Copy link
Member

Thanks a lot @drammock!

@sappelhoff sappelhoff merged commit d8f6109 into mne-tools:main Nov 5, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adjust canonical link?
2 participants