doc: update dependencies #921
Conversation
| pybv >= 0.6 | ||
| matplotlib >= 3.1.0 | ||
| pandas >= 0.24.0 | ||
| openneuro-py >= 2021.8 |
There was a problem hiding this comment.
I remove openneuro-py here because we only need it for the documentation (like nilearn, etc.) ... so it's good enough for it to live in docs/requirements.txt
There was a problem hiding this comment.
well full means also doc to me. It's also pure Python package. Otherwise we can do a [doc] install target
There was a problem hiding this comment.
okay, but then we'd need a couple of more packages there as well right? sphinx, nilearn, sphinx-copybutton, ...
Lines 1 to 10 in ff5cded
There was a problem hiding this comment.
To me, full means full functionality for a user, but no dev deps. Building docs is a dev operation. I don't think full needs to support this
There was a problem hiding this comment.
I rather agree with @hoechenberger here - but Richard: why would you then include openneuro-py in "full"?
EDIT: just saw that you approved, so you are probably fine with this.
Codecov Report
@@ Coverage Diff @@
## main #921 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 23 23
Lines 3488 3488
=======================================
Hits 3306 3306
Misses 182 182 Continue to review full report at Codecov.
|
|
Thanks @sappelhoff! |
closes #915
we will then need to push a commit to maint/0.9 and update the stable docs as well (will do once this is approved and merged)
Merge checklist
Maintainer, please confirm the following before merging: