Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add metadata to ZENODO core archive #953

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Feb 2, 2022

PR Description

Just adding some metadata to the code archive on Zenodo ... something I stumbled over while getting some other entries straight for my dissertation.

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #953 (80fbe04) into main (14625ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #953   +/-   ##
=======================================
  Coverage   94.40%   94.40%           
=======================================
  Files          25       25           
  Lines        3559     3559           
=======================================
  Hits         3360     3360           
  Misses        199      199           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14625ed...80fbe04. Read the comment docs.

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Is this something that we should adapt for MNE-Python as well?

@sappelhoff
Copy link
Member Author

I think that'd be nice. The docs are not very well advertised, but all that one can possibly specify is described here: https://developers.zenodo.org/#representation

Zenodo also accepts the relatively new CITATION.CFF files (see mne-tools/mne-python#9624), but I guess the interplay between .zenodo.json and Zenodo is a little more streamlined currently than with citation.cff (haven't tested that a lot until now).

@agramfort agramfort merged commit 7284226 into mne-tools:main Feb 2, 2022
@agramfort
Copy link
Member

thx @sappelhoff

@sappelhoff sappelhoff deleted the zenodo/metadata branch February 2, 2022 20:59
@sappelhoff sappelhoff mentioned this pull request Mar 16, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants