-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG, ENH, MRG] Pixels #976
Conversation
Codecov Report
@@ Coverage Diff @@
## main #976 +/- ##
==========================================
+ Coverage 94.57% 94.63% +0.06%
==========================================
Files 25 25
Lines 3597 3600 +3
==========================================
+ Hits 3402 3407 +5
+ Misses 195 193 -2
Continue to review full report at Codecov.
|
Ok, this should be good to go once everything comes back green, and allowing for pixels is 80% of the way there to allowing all the template coordinate frames since it sets the coordinate frame to unknown instead of head |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
Co-authored-by: Alexandre Gramfort <[email protected]>
Thanks @alexrockhill! |
Implements part of the fix from here: #973
This both adds support for ieeg data in pixels and prevents montages from being identity mapped to head when it's not appropriate. Before pixels data was not read in whereas "Other" coordinate frame data was. I see no reason MNE users can't analyze data in pixels, they just have to handle the coordinate frame themselves and have it set as "unknown" like the rest of the unsupported coordinate frames. This accompanies the issue that when the coordinate frame was "unknown" in a BIDS dataset it was mapped to head with an identity transform. I think best just to leave these in "unknown" so that people aren't confused that it's in head for some reason when it really isn't.
Merge checklist
Maintainer, please confirm the following before merging: