BUG: Fix regression with run_subprocess #11230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
drammock
approved these changes
Oct 7, 2022
|
Merging, CI fails are the matplotlib IndexError ones, which are already fixed upstream and should go away overnight. |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Oct 11, 2022
* upstream/main: BUG: Avoid warning in report.add_ica (mne-tools#11232) testing new features of website theme [circle deploy] (mne-tools#11033) BUG: Fix regression with run_subprocess (mne-tools#11230) DOC: fix mne-kit-gui package name (mne-tools#11231)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hoechenberger fixes a regression due to #11219. We shouldn't remove the
\nfrom thestdoutreturns, only remove it when actuallylogger.infoandlogger.warning'ing them.This should fix https://app.circleci.com/pipelines/github/mne-tools/mne-bids/4710/workflows/a2f8cafe-dd31-49cc-952d-3e46e06b5c14/jobs/6848, marking for merge-when-green