Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook password wrong: wrong output #96

Closed
dag7dev opened this issue Apr 22, 2021 · 3 comments
Closed

Facebook password wrong: wrong output #96

dag7dev opened this issue Apr 22, 2021 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@dag7dev
Copy link

dag7dev commented Apr 22, 2021

immagine
It says "Facebook user list is empty". This is simply not true, since I entered an incorrect password it should say "wrong password".

Python version: 3.9.0
OS: Windows 10 Version 10.0.19042 Build 19042
Architecture: x64

@dag7dev dag7dev changed the title Facebook user list is empty Facebook password wrong: wrong output Apr 22, 2021
@mobeigi mobeigi added bug Something isn't working question Further information is requested labels Apr 23, 2021
@mobeigi
Copy link
Owner

mobeigi commented Apr 23, 2021

Howdy,

The method in which we check if login successful is quite hacky.
We do some 200 checks and check to see if certain elements exist in the DOM.

This would be improved if we did an extra network call to some privileged endpoint although it's low priority.

Out of curiosity, is your FB language non-English?

@mobeigi mobeigi added the good first issue Good for newcomers label Apr 23, 2021
@dag7dev
Copy link
Author

dag7dev commented Apr 23, 2021

OOT: all it started because I typed wrong password by mistake and it told me that error.
I triple checked out that password, finding out that I was wrong (obviously) and the tool works great!

To answer your question: Ding-ding-ding! Correct!

Honestly I don't know how you managed to scrap the website, but to check if a user is log or not I could advise to simply check if c_user in cookies is set or not for facebook.com

In fact, that represents your userid, which it would be null if you are unlogged or with invalid credentials.

@mobeigi
Copy link
Owner

mobeigi commented Apr 23, 2021

Sounds like a good plan.
Feel free to put up a PR if you can :)

@mobeigi mobeigi removed the question Further information is requested label May 2, 2021
@mobeigi mobeigi closed this as completed in 1decea1 May 2, 2021
@mobeigi mobeigi added this to the 1.2.3 milestone May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants