Split LocalMounter.Mount into Windows and Unix #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to current deficiencies in the Windows implementation of containerd's Mount.Mount, we need different behaviour for mounting on Windows and Unix platforms. Specifically: * Windows mounts can only mount in-place, and hence only one mount should be in the list. * BuildKit doesn't own the mount directory, so should not try and remove it on unmount. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
AkihiroSuda
approved these changes
Jul 16, 2020
tonistiigi
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to current deficiencies in the Windows implementation of containerd's Mount.Mount, we need different behaviour for mounting on Windows and Unix platforms.
Specifically:
See discussion leading to #1314 (comment)
Contributes towards #616