Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace promise.allsettled with @ungap/promise-all-settled; closes #4474 #4476

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

boneskull
Copy link
Contributor

@boneskull boneskull commented Oct 13, 2020

This is a workaround for npm/cli#1113; see #4474 for how this impacts Mocha. It's very odd behavior indeed.

After this change, running npm install --production with mocha in the devDependencies does not install any of Mocha's production deps nor its transitive production deps.

I don't have a great strategy for automating the testing of this this (yet), but what you can do is:

  1. Pull this PR into a working copy
  2. Run npm install
  3. Run npm pack which will result in a .tgz
  4. Grab https://github.com/danludwig/npm-module-bug-reports and navigate into mocha-2020-10-bug directory
  5. In this dir, update mocha in package.json to point to the tarball on disk (relative or absolute path) and rm package-lock.json; rm -rf node_modules to be sure it's a clean slate
  6. Run npm install --production. node_modules should not even exist (or if you did create it, it should be empty)

cc @danludwig

@boneskull boneskull added type: bug a defect, confirmed by a maintainer semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Oct 13, 2020
@boneskull boneskull self-assigned this Oct 13, 2020
@coveralls
Copy link

coveralls commented Oct 13, 2020

Coverage Status

Coverage remained the same at 94.078% when pulling b796371 on boneskull/issue/4474 into 31116db on master.

@boneskull boneskull merged commit 60e3662 into master Oct 14, 2020
@boneskull boneskull added this to the next milestone Oct 14, 2020
@boneskull boneskull deleted the boneskull/issue/4474 branch October 14, 2020 22:58
@boneskull boneskull modified the milestones: next, v8.2.0 Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants