replace promise.allsettled with @ungap/promise-all-settled; closes #4474 #4476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for npm/cli#1113; see #4474 for how this impacts Mocha. It's very odd behavior indeed.
After this change, running
npm install --production
withmocha
in thedevDependencies
does not install any of Mocha's production deps nor its transitive production deps.I don't have a great strategy for automating the testing of this this (yet), but what you can do is:
npm install
npm pack
which will result in a.tgz
mocha-2020-10-bug
directorymocha
inpackage.json
to point to the tarball on disk (relative or absolute path) andrm package-lock.json; rm -rf node_modules
to be sure it's a clean slatenpm install --production
.node_modules
should not even exist (or if you did create it, it should be empty)cc @danludwig