-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add example of generating tests with a HOF #4494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Good addition. I have a couple suggestions--happy to discuss.
yeah that coveralls failure doesn't make sense. we've had this problem before. unclear to me if the culprit is coveralls or nyc... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates. I have some more suggestions
Test failure looks like timing-related flake; unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed one
Co-authored-by: Christopher Hiller <[email protected]>
Co-authored-by: Christopher Hiller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxwellgerber thank you
The cancelled browser test is off-topic.
Requirements
Description of the Change
Quick docs update showing a workaround with some common issues run into w/data-driven tests.
Namely, it's very hard to run a single testcase from an IDE because tests inside a
.forEach
callback aren't detected, Comparewith
Alternate Designs
N/A (docs update)
Why should this be in core?
N/A (docs update)
Benefits
This approach has been useful for me & my team - hope it can be useful for someone else too
Possible Drawbacks
Slightly more verbose than pure data-driven approach.
Applicable issues