Support color scheme dark #4896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
greggman
force-pushed
the
support-color-scheme-dark
branch
2 times, most recently
from
2233984
to
4217396
Compare
Adds CSS for prefers-color-scheme: dark
greggman
force-pushed
the
support-color-scheme-dark
branch
from
4217396
to
4dada16
Compare
|
I will merge this in a few days. |
|
@outsideris please set the according labels, milestones and close the relevant issues. It's unfair - if you merge PR's - to leave the cleaning to others. Thank you. |
|
Sorry, I missed them. |
outsideris
added
the
area: website
|
@outsideris have you tested anything of this before merging?
How do you set the dark mode, how to overwrite the settings? Any docs? |
|
@juergba Sure. It follows the system theme on OS. I tested it on my macOS. |
|
The percentage color in the circle is different from mine. Are you using windows?
|
|
Yes, Windows and Chrome. I have to refresh then the circle gets filled. |
juergba
added
the
semver-minor
kleisauke
reviewed
Oct 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Adds CSS to support prefers-color-scheme: dark as well as a small bit of JavaScript for the progress indicator.
Alternate Designs
Change the progress indicator to use SVG which can by styled by CSS. But one change at a time suggests that should be a separate change.
Why should this be in core?
Because bright screens can be annoying in certain situation. The motivation for adding a dark mode was I was working on a flight. All the window shades are pulled down. All the terminals and editors I run were in dark mode but then when I went to run the tests, BOOM!, I'm lighting up all the seats around me.
Benefits
People who like dark mode, which is becoming fairly popular, can get mocha in dark mode.
Possible Drawbacks
Browsers that don't support CSS
varwill have issues. Basically IEApplicable issues
#4895