-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standard Promise.allSettled instead polyfill #4905
Conversation
Signed-off-by: Outsider <[email protected]>
@outsideris I guess this PR makes sense. |
Oops! Sorry for korea link. And you can see 12.9.0 release note. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outsideris thank you for your explanations and this PR.
Description of the Change
We've introduced @ungap/promise-all-settled in #4476.
And Node.js support Promise.allSettled in Node 12.9.0.
So, we don't need polyfill anymore because we support Node 14+.
Why should this be in core?
We don't need polyfill anymore.
Benefits
dependency is reduced.
Possible Drawbacks
N/A