-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude auto-generated contents from docs/index.md; closes #3713 #3734
Conversation
* Remove auto-generated contents from docs/index.md * Make documents from temporally copied file docs/index.md.tmp * Add docs/index.md.tmp to the .gitignore list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. This removes the auto-generated content, but the idea would be that the content is generated as part of the build process. It looks like you're halfway there--just need to ensure the temporary file is processed by the docs.preprocess
script(s).
61b6bb4
to
ccc431f
Compare
@wanseob I've resolved the conflicts and rebased this branch onto |
Appreciate your feedback and rebasing @boneskull. I added a new commit to remove the tmp file at the post-processing step. But I'm wondering that isn't it enough to exit with code 0 when it executes |
Closing out to keep our queue small. Someone please yell at me if this should be re-opened though. Cheers! 🤎 |
Description of the Change
Benefits
No more frustrating jobs after
npm start docs
.Applicable issues
This PR handles #3713