Improvements to binary and string variables #50
+62
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -332,7 +332,7 @@ TEST_CASE("Invalid Binary variable - non-hexadecimal char second in byte tuple", | |||
| const char* xmldir = FMI3_TEST_XML_DIR "/variable_test/invalid/binaryStart2"; | |||
|
|
|||
| fmi3_import_t* xml = fmi3_testutil_parse_xml(xmldir); | |||
| REQUIRE(xml != nullptr); | |||
| REQUIRE(xml != nullptr); /* TODO how do we want this to work? */ | |||
There was a problem hiding this comment.
Only remaining action is to figure out how we want to handle this scenario, currently the tests fail on this branch, but the tests only fail here.
| @@ -321,7 +321,7 @@ TEST_CASE("Invalid Binary variable - non-hexadecimal char first in byte tuple", | |||
| const char* xmldir = FMI3_TEST_XML_DIR "/variable_test/invalid/binaryStart1"; | |||
|
|
|||
| fmi3_import_t* xml = fmi3_testutil_parse_xml(xmldir); | |||
| REQUIRE(xml != nullptr); | |||
| REQUIRE(xml != nullptr); /* TODO how do we want this to work? */ | |||
There was a problem hiding this comment.
Only remaining action is to figure out how we want to handle this scenario, currently the tests fail on this branch, but the tests only fail here.
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| <CoSimulation modelIdentifier="VariableTypes"/> | |||
| <ModelVariables> | |||
| <Binary name="binary_array" valueReference="122" maxSize="28" initial="exact" description="Testing binary arrays"> | |||
| <Binary name="binary_array" valueReference="125" maxSize="28" initial="exact" description="Testing binary arrays"> | |||
There was a problem hiding this comment.
125 was an arbitrary change I did to simplify debugging (since there are other tests with vr 122)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.