Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we adopt Malvid? #53

Open
pankajpatel opened this issue Jul 6, 2018 · 6 comments
Open

Can we adopt Malvid? #53

pankajpatel opened this issue Jul 6, 2018 · 6 comments
Assignees

Comments

@pankajpatel
Copy link
Member

https://malvid.io/
Repo: https://github.com/Malvid/Malvid
Demo: https://malvid.io/ui/#/806a662853767cf69a120de2ef3618cb644edbc0/view

@nogizhopaboroda
Copy link
Member

Not sure if i got the question. What do you mean by adopting it?

@pankajpatel
Copy link
Member Author

adopting it means, maybe we can have our stories inside this tool itself

or if not, go by this design.

@nogizhopaboroda
Copy link
Member

ok, but what benefits will it bring?

design - why not, looks lovely

@nogizhopaboroda
Copy link
Member

nogizhopaboroda commented Jul 6, 2018

i still don't get a question. if you want to render stories in that tool, then it's not related to this repo.
could you please explain the proposal a bit more detailed? like how it's gonna work. just to give a clue

@pankajpatel
Copy link
Member Author

I would like to try both ways.

  1. Render our stories in this Tool if possible
  2. If not possible, let's adopt the design

I created the issue here because the Stories are still constructs of this repo. I haven't explored the tool more thoroughly, just put it here to give it a try in later time. Or if anyone come's across, they can also do so to give a quick feedback on the possibilities.

@pankajpatel pankajpatel self-assigned this Jul 6, 2018
@nogizhopaboroda
Copy link
Member

nogizhopaboroda commented Jul 6, 2018

about design - it seems like a good way to do it would be to provide themes so that user can decide on their own which design to choose. it can be matter of storybook config file. something like:

// .storybook/additional.js

import 'modulor-storybook/themes/dark.css'

or

// .storybook/additional.js

import 'modulor-storybook/themes/pink'
//modulor-storybook/themes/pink/index.js

import './theme.css'

this would keep current styles simple (e.g. i personally like current minimalistic design, but others might like fancy ones)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants