Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual order automatically set to complete #583

Closed
hansvereyken opened this issue Nov 11, 2022 · 4 comments
Closed

Virtual order automatically set to complete #583

hansvereyken opened this issue Nov 11, 2022 · 4 comments

Comments

@hansvereyken
Copy link

Describe the bug
When placing a virtual order (none of the items requires shipment (eg: virtual gift cards)), the order status is set to complete instead of the status configured in Stores -> Settings -> Configuration -> Mollie -> Advanced -> Statuses -> Status Processing

Used versions

  • Magento Commerce (Adobe Commerce) 2.4.5-p1:
  • Mollie 2.13.0:
  • PHP 8.1

To Reproduce
Steps to reproduce the behavior:

  1. Place an order only containing virtual products
  2. Go through the checkout, pay for the order
  3. Go to the admin, check the newly created order status

Expected behavior
The status is set to the status configured in Stores -> Settings -> Configuration -> Mollie -> Advanced -> Statuses -> Status Processing

Actual behavior
The order is set to 'complete'

Additional context
This probably is Magento's doing, since no shipping is required, it will set it to complete automatically. But this is a problem for our bookkeeping integration.

@Marvin-Magmodules
Copy link
Collaborator

Hi @hansvereyken, this is intended behavior as these orders do not require a shipment and thus do not touch the processing state. A processing state holds orders that have an invoice and still require a (full)shipment. So setting a processing status does not apply to these orders.

@hansvereyken
Copy link
Author

Yes, that's what I expected. As mentioned, this is a problem for our bookkeeping integration, it will only process 'processing' orders. The virtual orders never reach this state. According to Magento's documentation, it's the payment module setting the after-payment-order-status, apparently this excludes virtual orders (not documented as far as I can see).

@Marvin-Magmodules
Copy link
Collaborator

Hi @hansvereyken, yes indeed. We are closing this issue now as this behavior is as intended and also not an issue that is related to the Mollie module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants