Fix for add/subtract when crossing a tz offset #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using 'add' or 'subtract' (or maybe other) moment.js functions, result was wrong if date passes through tz offset change. See discussion in issue moment#28 for more details. This commit includes a small suite of tests, along with a small fix in the spirit of that suggested by @icambron [here][1]: "If we're changing a date or month, just [...] change the offset without touching the time." [1]: moment#28 (comment) This requires an associated change to the moment project, to support this second argument (though it will not fail any harder than it currently does, if running with an older version of moment).
kroo
added a commit
to kroo/moment
that referenced
this pull request
Jan 15, 2014
This adds a second argument to setters that provides a hint to updateOffset to not change hours/minutes when crossing a tz boundary. This is frequently desirable when modifying part of an existing moment object directly. It further passes this argument whenever adding / subtracting days or months, fixing an issue with moment-timezone (moment/moment-timezone#28). See the corresponding PR for moment-timezone here: moment/moment-timezone#53.
ichernev
added a commit
that referenced
this pull request
Feb 6, 2014
Fix for add/subtract when crossing a tz offset The tests would pass with moment version after (not including) 2.5.1.
ichernev
pushed a commit
to moment/moment
that referenced
this pull request
Feb 6, 2014
This adds a second argument to setters that provides a hint to updateOffset to not change hours/minutes when crossing a tz boundary. This is frequently desirable when modifying part of an existing moment object directly. It further passes this argument whenever adding / subtracting days or months, fixing an issue with moment-timezone (moment/moment-timezone#28). See the corresponding PR for moment-timezone here: moment/moment-timezone#53.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using 'add' or 'subtract' (or maybe other) moment.js functions, result was wrong if date passes through tz offset change. See discussion in issue #28 for more details.
This commit includes a small suite of tests, along with a small fix in the spirit of that suggested by @icambron here: "If we're changing a date or month, just [...] change the offset without touching the time."
This requires an associated change to the moment project (moment/moment#1419), to support this second argument (though it will not fail any harder than it currently does, if running with an older version of moment).