implement java.sql.Statement #18
Open
+827
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,8 +76,6 @@ tasks.withType<JavaCompile>().configureEach { | |||
| options.errorprone { | |||
| disableWarningsInGeneratedCode.set(true) | |||
| option("NullAway:AnnotatedPackages", "com.mongodb.hibernate") | |||
| option("NullAway:ExcludedFieldAnnotations", "org.mockito.Mock") | |||
| option("NullAway:ExcludedFieldAnnotations", "org.mockito.InjectMocks") | |||
There was a problem hiding this comment.
found the above two options not taking effect
| @@ -272,11 +273,11 @@ public void clearWarnings() throws SQLException { | |||
| @Override | |||
| public <T> T unwrap(Class<T> unwrapType) throws SQLException { | |||
| checkClosed(); | |||
| throw new SQLFeatureNotSupportedException("Unwrap() unsupported"); | |||
| throw new SQLFeatureNotSupportedException("unwrap unsupported"); | |||
There was a problem hiding this comment.
simulating the message pattern elsewhere
| } | ||
|
|
||
| @Override | ||
| public boolean isWrapperFor(Class<?> iface) throws SQLException { | ||
| public boolean isWrapperFor(Class<?> iface) { |
There was a problem hiding this comment.
seems we'd better eliminate unused exceptions from method signature to avoid troubling method user to catch the checked exception which will never be thrown.
| default: | ||
| throw new SQLFeatureNotSupportedException( | ||
| "Unsupported (supported commands include 'insert', 'update' and 'delete') command: " | ||
| + commandName); |
There was a problem hiding this comment.
we might need dicusson on what commands we support. The above three was copied from POC, not necessarily the best.
NathanQingyangXu
force-pushed
the
HIBERNATE-16-new
branch
from
c735032 to
e5fb484
Compare
NathanQingyangXu
force-pushed
the
HIBERNATE-16-new
branch
from
e5fb484 to
092047c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/HIBERNATE-16
java.sql.Statementis the parent class ofjava.sql.PreparedStatement, which mainly focused on parameterization. Internally after parameters passed intoPreparedStatementare collected and resolved, the resulting SQL would still be executed injava.sql.Statement, including:We have separate tickets for the first and third entry above, but the second entry is in the scope of this PR. The method parameter or
sqlcould come from HQL or native MQL. Regardless, for now we simply feed it (parameterization from HQL will be done in another ticket implementingjava.sql.PreparedStatement) to Mongo Java driver.The implementation internally is based on
MongoDatabase#runCommand(ClientSession, Bson), so we need to passMongoDatabaseall the way fromMongoConnectionProvider. Currently a@NullableMongoDatabasewill be used for now and it could be changed later (when we finished discussion on how to get database somewhere).Most of the unit testing focused on the edge cases of
int executeUpdate(String)by mocking. After evergreen integration work is done, we might later add integration testing cases on it.