Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't embed libSkiaSharp in the assemblies #1296

Merged
merged 24 commits into from
Jun 10, 2020
Merged

Don't embed libSkiaSharp in the assemblies #1296

merged 24 commits into from
Jun 10, 2020

Conversation

mattleibow
Copy link
Contributor

Description of Change

Instead of embedding the native assets into the assemblies, which not only slow down build times when extracting, but also can't be excluded or controlled.

Bugs Fixed

None.

API Changes

None

Behavioral Changes

None visible, but now using .targets files to include native assets.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow marked this pull request as draft May 20, 2020 06:23
@mattleibow mattleibow changed the base branch from develop to master June 8, 2020 11:57
@mattleibow mattleibow marked this pull request as ready for review June 10, 2020 02:10
@mattleibow mattleibow merged commit 69c89d5 into master Jun 10, 2020
@mattleibow mattleibow deleted the dev/no-embed branch June 10, 2020 19:04
@mattleibow mattleibow added this to the v2.80.0 milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant