This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
Fix TargetFrameworkRootPathFallback when MSBuild API is used in different process #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent process When reading the TargetFrameworkRootPathFallback from the app.config, we need use the configuration file from the current MSBuild Exe Path rather than the one from the current process. This is consistent with the behavior of `ToolsetConfigurationReaderHelpers.ConfigurationFileMayHaveToolsets()`.
DustinCampbell
added a commit
to DustinCampbell/omnisharp-roslyn
that referenced
this pull request
Jul 24, 2017
This includes PR mono/msbuild#22 to fix an issue with TargetFrameworkRootPath fallbacks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the TargetFrameworkRootPathFallback from the app.config, we need use the configuration file from the current MSBuild Exe Path rather than the one from the current process. This is consistent with the behavior of
ToolsetConfigurationReaderHelpers.ConfigurationFileMayHaveToolsets().This addresses the particular scenario of using MSBuild as an API within another application (in my case OmniSharp).
cc @radical