質問を登録していない状態でSTARTを押すとフラッシュメッセージを表示するようにした #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moyasine
changed the title
shogo-mitomo
requested changes
Sep 21, 2017
| else | ||
| return redirect_to over_questions_url | ||
| end | ||
| end |
There was a problem hiding this comment.
別のページにリダイレクトするのでは今までとあまり変わらないので、フラッシュメッセージを出すようにした方がユーザビリティがいいと思うんだけど、どうかな？
|
フラッシュメッセージにしました。がスタイルがかっこよくないので全体のデザイン変更と合わせて変更できたらと思います。 |
moyasine
changed the title
|
スタイルは仮のものを使用しています。 |
|
コンフリクトしてるし、変更後のデザインと合っていないので、クローズします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #89
Questionが登録されていない状態のみ、問題作成のページに飛ぶようにしました。