Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MOODLE_DOCKER_DB optional #307

Open
fulldecent opened this issue Nov 25, 2024 · 3 comments
Open

Make MOODLE_DOCKER_DB optional #307

fulldecent opened this issue Nov 25, 2024 · 3 comments

Comments

@fulldecent
Copy link
Contributor

In order to setup moodle-docker, it is necessary that you will pick a database.

Many people do not care which database is running. In fact most people that use Moodle do not care which database is running.

So I ask that MOODLE_DOCKER_DB be removed as a required variable to setup moodle-docker.

This removes one line of boilerplate from everybody using this project.

This issue is part of #304, the initiative to make it easier for anybody to get started with trying or developing on Moodle.

@fulldecent
Copy link
Contributor Author

And yes, this means that the Moodle project should choose one database that it recommend as the starting point for development.

That is a reasonable thing to ask of the Moodle project to do rather than require every developer to spend brain cycles on this before they are able to use Moodle.

@scara
Copy link
Contributor

scara commented Nov 25, 2024

Hi @fulldecent,

That is a reasonable thing to ask of the Moodle project to do rather than require every developer to spend brain cycles on this before they are able to use Moodle.

it depends on the nature of what developed: back-end stuff could be strongly db-dependent, especially in testing the changes around queries.

HTH,
Matteo

@fulldecent
Copy link
Contributor Author

fulldecent commented Nov 25, 2024

That is absolutely correct. And most people are not doing strongly db-dependent backend stuff.

So a reasonable default database could make this project multiple minutes easier to approach for everybody else by making that option have a default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants