Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deambiguate imported functions #25

Open
moodymudskipper opened this issue Mar 18, 2024 · 1 comment
Open

deambiguate imported functions #25

moodymudskipper opened this issue Mar 18, 2024 · 1 comment

Comments

@moodymudskipper
Copy link
Owner

Use case:

  • A project uses a lot of library calls, without conflicted.
  • We converted them to @ import
  • devtools::check complains that we are overriding a ton of functions

Solution:

  • A function to convert all import tags to importFrom
  • A function to resolve the ambiguities, by just enumerating them, and we have to remove the redundant entry and check the code manually for usage (maybe we can use this feature similar to find in files, forgot the name, see my aborted PR in golem) so we can add :: where needed
@moodymudskipper
Copy link
Owner Author

the keyword is source markers: see ThinkR-open/golem@398b5bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant