Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed tests and other side-effect errors related to global shortcut keys #218

Closed
bingenito opened this issue Feb 11, 2019 · 0 comments
Closed
Assignees

Comments

@bingenito
Copy link
Member

PR #214 introduced some failed tests that were not caught because of #217

Global shortcuts require minimum OpenFin runtime of 9.61.32.34
Unavailable in OpenFin is unavailable on container: failed

ElectronGlobalShortcutManager
invokes underlying Electron
{ Error: Cannot find module 'electron'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
at Function.Module._load (internal/modules/cjs/loader.js:507:25)
at Module.require (internal/modules/cjs/loader.js:637:17)
at require (internal/modules/cjs/helpers.js:22:18)
at new ElectronContainer (/home/travis/build/Morgan-Stanley/desktopJS/packages/desktopjs-electron/build/src/electron.js:9:31216)
at UserContext. (/home/travis/build/Morgan-Stanley/desktopJS/packages/desktopjs-electron/build/tests/electron.spec.js:969:29)
at QueueRunner.attempt (/home/travis/build/Morgan-Stanley/desktopJS/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:4816:44)
at QueueRunner.run (/home/travis/build/Morgan-Stanley/desktopJS/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:4854:25)
at runNext (/home/travis/build/Morgan-Stanley/desktopJS/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:4784:18)
at next (/home/travis/build/Morgan-Stanley/desktopJS/node_modules/jasmine-core/lib/jasmine-core/jasmine.js:4791:11) code: 'MODULE_NOT_FOUND' }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant