Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught TypeError: Cannot read property 'target' of undefined #246

Closed
bbenezech opened this issue Sep 13, 2016 · 2 comments
Closed

Uncaught TypeError: Cannot read property 'target' of undefined #246

bbenezech opened this issue Sep 13, 2016 · 2 comments
Labels
bug

Comments

@bbenezech
Copy link

bbenezech commented Sep 13, 2016 •
edited by moroshko
Loading

react-autosuggest/src/Autosuggest.js

Line 126 in a759a25

event.detail.target || // This is for testing only. Please show be a better way to emulate this.

event.detail can be undefined with weird custom events.

Happened with Trix editor when undoing with CTRL+Z while an autosuggest is present elsewhere.

Yep. Edge case.

Proposed fixes:

  • find a "a better way to emulate this" 😜
  • be more defensive 💂
  • act like we don't care 🙉
@moroshko moroshko added the bug label Sep 16, 2016
@moroshko
Copy link
Owner

Thanks for raising the issue!

I went with "be more defensive 💂" for now.

@moroshko
Copy link
Owner

This is fixed in v6.0.4 now.

Thanks again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbenezech @moroshko