Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behaviour of renderSuggestion query #504

Closed
jgresty opened this issue Feb 1, 2018 · 1 comment
Closed

Inconsistent behaviour of renderSuggestion query #504

jgresty opened this issue Feb 1, 2018 · 1 comment

Comments

@jgresty
Copy link

jgresty commented Feb 1, 2018

There is inconsistency about the query argument passed to renderSuggestion, when there is a value in the input then it works as expected. However when the input field is empty then it receives the value of whichever selection is highlighted.

See codepen: https://codepen.io/anon/pen/wyKgOp

  1. Allow shouldRenderSuggestions with empty input
  2. Focus on the input field
  3. Press Down a few times and observe the query argument passed
  4. Clear input and enter a character
  5. Press Down a few times and observe the query argument passed

Observed behaviour: Query argument passed is value of selected suggestion when no input is initially empty
Expected behaviour: Query argument passed is empty string when input is initially empty

@moroshko moroshko changed the title Inconsistant behaviour around renderSuggestion Inconsistent behaviour of renderSuggestion query Feb 4, 2018
@moroshko
Copy link
Owner

moroshko commented Feb 4, 2018

Thanks for reporting!
Fixed and published.

@moroshko moroshko closed this as completed Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants