Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid results for DIA and ELL on GPU backends with LayoutRight #49

Open
4 tasks
cstyl opened this issue Dec 22, 2022 · 0 comments
Open
4 tasks

Invalid results for DIA and ELL on GPU backends with LayoutRight #49

cstyl opened this issue Dec 22, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@cstyl
Copy link
Member

cstyl commented Dec 22, 2022

When a DiaMatrix or EllMatrix is constructed with Kokkos::LayoutRight returns invalid results on Morpheus::Cuda and Morpheus::HIP for multiply() and update_diagonal() algorithms, due to improper construction of the linearized index in each of the following kernels:

  • update_dia_diagonal_kernel() in core/src/impl/Dia/Kernels/Morpheus_MatrixOperations_Impl.hpp
  • spmv_dia_kernel() in core/src/impl/Dia/Kernels/Morpheus_Multiply_Impl.hpp
  • update_ell_diagonal_kernel() in core/src/impl/Ell/Kernels/Morpheus_MatrixOperations_Impl.hpp
  • spmv_ell_kernel() in core/src/impl/Ell/Kernels/Morpheus_MatrixOperations_Impl.hpp
@cstyl cstyl added the bug Something isn't working label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cstyl